Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect against stray EOFs #44

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Protect against stray EOFs #44

wants to merge 2 commits into from

Commits on Aug 27, 2020

  1. Protect against stray EOFs

    Unfortunately:
    
    1. Read can read bytes and return an EOF at the same time (could cause us to
    fail to parse something that's actually correct).
    2. ReadByte is not allowed to do this (fixed in PeekByte).
    3. Returning EOF on _actual_ error cases can cause the error to be silently
    dropped somewhere up the stack (where the EOF may be interpreted as "I'm done").
    I've replaced EOF with ErrUnexpectedEOF where appropriate.
    
    This crap really shouldn't be necessary, but such is life.
    Stebalien committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    25f41c9 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2021

  1. Configuration menu
    Copy the full SHA
    3907992 View commit details
    Browse the repository at this point in the history