Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email on closed box page #287

Merged
merged 2 commits into from
Nov 2, 2018
Merged

Email on closed box page #287

merged 2 commits into from
Nov 2, 2018

Conversation

dethos
Copy link
Collaborator

@dethos dethos commented Oct 26, 2018

This pull request solves issue #282.

Summary:

  • Fixes translation
  • Adds email when name is not setup for a given account

@dethos dethos requested a review from pjaneiro November 2, 2018 12:54
tomascarvalho
tomascarvalho approved these changes Nov 2, 2018
View reviewed changes
Copy link
Contributor

@tomascarvalho tomascarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dethos dethos merged commit 188ca35 into master Nov 2, 2018
@dethos dethos deleted the fix_closed_box branch November 2, 2018 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomascarvalho tomascarvalho tomascarvalho approved these changes

@pjaneiro pjaneiro Awaiting requested review from pjaneiro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dethos @tomascarvalho