Instance information #262
Instance information #262
Conversation
dethos
force-pushed
the
instance-information
branch
from
9a6f412
to
a3188a4
Compare
locale/pt_PT/LC_MESSAGES/django.po
Outdated
| "\">Open an issue on the project board with your question</a> " | ||
| msgstr "" | ||
| "<a href=\"https://github.com/whitesmith/hawkpost/issues\" class=\"testelinks" | ||
| "\">Abra uma questão no forúm problemas do projecto</a> " |
There was a problem hiding this comment.
@dethos Typo on "forúm" (should be "fórum").
Additionally, the phrase doesn't seem correct, maybe it was re-written and lost some of its original form?
.env.sample
Outdated
| SENTRY_URL= | ||
|
|
||
| # (Optional) Information about the hawkpost instance and administrator | ||
| SUPPORT_NAME= |
There was a problem hiding this comment.
@dethos Since SUPPORT_NAME and SUPPORT_EMAIL are rendered unconditionally (i.e. there's no if testing if they have been defined) we should probably mark them as mandatory; while omitting them does not break functionality it causes the labels to appear next to "nothing", and the goal of this PR is to distinguish a custom instance from https://hawkpost.co, so I see no harm in advising the user to provide them anyway.
hawkpost/settings/common.py
Outdated
| SUPPORT_NAME = os.environ.get("SUPPORT_NAME", "") | ||
| SUPPORT_EMAIL = os.environ.get("SUPPORT_EMAIL", "") | ||
| INSTANCE_DESCRIPTION = os.environ.get("INSTANCE_DESCRIPTION", "") | ||
| VERSION = "1.1.0" |
There was a problem hiding this comment.
@dethos This is going to be the canonical source for the Hawkpost's version? Shouldn't this be moved way up this file, since it should be updated frequently? What is going to be our version bump policy from now on?
There was a problem hiding this comment.
This should be in sync with the release on the project repository. But I'm open to discuss a better approach to this, so feel free to open an issue. 👍
This pull request is the minimal implementation of the issue #260, that is in discussion.
The idea is to give user a little more context about who is running a particular "instance" or "deployment" of Hawkpost.