Reduce the number of Window objects exposed on the Window object #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, when a child browsing context is cross-origin from the perspective of the document it's in, only include it as a property on the Window object when it's browsing context name matches that of the name content attribute value it is included through. This also cleans up the definition of browsing context name by aligning it with how it's used. Namely that it's the empty string by default rather than unset. It also makes it clearer that "child browsing context name property set" belongs to a Window object and how the referenced "active document" is obtained from that Window object. Fixes #257.
| the <span data-x="browsing context name">name</span> of the <span>browsing context</span> to the | ||
| new value.</p> | ||
| <span>browsing context</span>; and, on setting, set the <span data-x="browsing context | ||
| name">name</span> of the <span>browsing context</span> to the new value.</p> | ||
|
|
||
| <p class="note">The name <a href="#resetBCName">gets reset</a> when the browsing context is | ||
| navigated to another domain.</p> |
There was a problem hiding this comment.
maybe update this to "origin" (with cross links) while you're here?
This was referenced May 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, when a child browsing context is cross-origin from the
perspective of the document it's in, only include it as a property on
the Window object when it's browsing context name matches that of the
name content attribute value it is included through.
This also cleans up the definition of browsing context name by
aligning it with how it's used. Namely that it's the empty string by
default rather than unset. It also makes it clearer that "child
browsing context name property set" belongs to a Window object and
how the referenced "active document" is obtained from that Window
object.
Fixes #257.