Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"nested through" usage is wrong #4409

Closed
annevk opened this issue Mar 4, 2019 · 1 comment · Fixed by #5091
Closed

"nested through" usage is wrong #4409

annevk opened this issue Mar 4, 2019 · 1 comment · Fixed by #5091
Labels
topic: browsing context

Comments

@annevk
Copy link
Member

annevk commented Mar 4, 2019

This is related to #1336.

In one case we use documents on both sides of "nested through". This is wrong as one side has to be a browsing context.

In one case we use "in a document" whereas it has to talk about connected.

I suspect we can remove this concept and use browsing context container's node document instead.
@annevk
Copy link
Member Author

annevk commented Oct 21, 2019

I think this is a subset of #5020.

This was referenced Nov 15, 2019
Merged
Merged
annevk added a commit that referenced this issue Nov 22, 2019
@annevk
Give browsing context an explicit container
7b4964a 
This generally sets out the infrastructure for a more secure model for working with browsing contexts, as outlined in #5020.

* Adds browsing context's container
* Adds browsing context's container document
* Makes "update the rendering" account for browsing contexts in shadow trees
* Removes nested through; closes #4409.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: browsing context
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Give browsing contexts an explicit container whatwg/html
1 participant
@annevk