This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Fix GUI clippy issues #1953
Merged
Fix GUI clippy issues #1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust 1.44 made `vec![]` expand to `Vec::new()` (rust-lang/rust#70632). As such clippy is now (somewhat correctly) interpreting that the macro could be used points-free. clippy should be smart enough to not substitute the expanded macro, but for now we can silence the errors by using a points-free constructor. Fixes #1949. Signed-off-by: Joe Grund <jgrund@whamcloud.io>
ip1981
approved these changes
Jun 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust 1.44 made
vec![]expand toVec::new()(rust-lang/rust#70632).As such clippy is now (somewhat correctly) interpreting that the macro could be used points-free.
clippy should be smart enough to not substitute the expanded macro, but
for now we can silence the errors by using a points-free constructor.
Fixes #1949.
Signed-off-by: Joe Grund jgrund@whamcloud.io
This change is