Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Float Pane #5576

Draft
wants to merge 35 commits into
base: main
Choose a base branch
from
Draft

Float Pane #5576

wants to merge 35 commits into from
+1,049 −88

Commits on Jun 23, 2024

  1. Attempt at float pane

    @e82eric
    e82eric committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    5ee02e4 View commit details
    Browse the repository at this point in the history

  2. Try to prevent changes when a float is being shown

    @e82eric
    e82eric committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    518e0c8 View commit details
    Browse the repository at this point in the history

  3. Trying to get cli float-pane to work

    @e82eric
    e82eric committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    be7d669 View commit details
    Browse the repository at this point in the history

  4. Reverted changes to allow float pane size configuration

    @e82eric
    e82eric committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    6da5f03 View commit details
    Browse the repository at this point in the history

  5. Experiment with float borders

    @e82eric
    e82eric committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    83b7974 View commit details
    Browse the repository at this point in the history

  6. float padding config

    @e82eric
    e82eric committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    44c8a21 View commit details
    Browse the repository at this point in the history

  7. Remove float pane from tab.panes

    @e82eric
    e82eric committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    3bcf229 View commit details
    Browse the repository at this point in the history

  8. Removed pane_id where not needed

    @e82eric
    e82eric committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    f9de55f View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. More accurate float borders

    @e82eric
    e82eric committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    543af2b View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Handle Resize

    @e82eric
    e82eric committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    275567a View commit details
    Browse the repository at this point in the history

  2. Better mouse handling

    @e82eric
    e82eric committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    203e362 View commit details
    Browse the repository at this point in the history

  3. Clean up

    @e82eric
    e82eric committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    a3e7444 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2024

  1. Update float-pane to use cwd instead of home directory

    @e82eric
    e82eric committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    e8ee2a8 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2024

  1. prevent running pane manipulation actions when float pane is active

    @e82eric
    e82eric committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    128a1ca View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Updated float pane icons

    @e82eric
    e82eric committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    adba9f2 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. Floating pane: address initial feedback

    @e82eric
    e82eric committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    cd0ee5f View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2024

  1. Fix for not creating float pane in multiplexer

    @e82eric
    e82eric committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    e567786 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Support for floating panes in cli list-panes 

    Open questions
- Is (PaneNode, PaneNode) ok? Or should it be a type?
  - I think the tuple matches what Zellij has.
- Does the output need anything to indicate that the pane is a float?
  - I don't think Zellij supports list panes (It looked like there is a
    PR)
  - It looked like tmux popups are not persistent so I don't think it is
    applicable here
    @e82eric
    e82eric committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    55b9d8a View commit details
    Browse the repository at this point in the history

  2. Re-attach the floating pane

    @e82eric
    e82eric committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    7b20a18 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Fix for floating pane not being removed from all connected wezterms for 

    a single mux
    @e82eric
    e82eric committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    29d3988 View commit details
    Browse the repository at this point in the history

  2. Refactored remove_float_pane

    @e82eric
    e82eric committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    5ad7fe6 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Fix for floating pane not working with rotate_clockwise and 

    rotate_counter_clockwise
    @e82eric
    e82eric committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    b2e2b79 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Refactor compute_background_rect

    @e82eric
    e82eric committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    7fa4cca View commit details
    Browse the repository at this point in the history

  2. bump codec version

    @e82eric
    e82eric committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    d771fb7 View commit details
    Browse the repository at this point in the history

  3. Fix for resize not being applied to floating pane when updating window 

    size.
    @e82eric
    e82eric committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    20fbe7a View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. Attempt at being able to hide the floating pane

    @e82eric
    e82eric committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    e240f67 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2024

  1. Add is_floating to cli list

    @e82eric
    e82eric committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    0d05175 View commit details
    Browse the repository at this point in the history

  2. Update to only hide the floating pane if clicked outside of floating 

    pane.
    @e82eric
    e82eric committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    9534be7 View commit details
    Browse the repository at this point in the history

  3. Update so that cli active-pane --pane-id works floating pane. 

    Note if the floating pane is hidden it won't show if the terminal window isn't
focused (it will aprear when the terminal window gets focus), I think this matches the behavior of splits but is more noticeable with the floating pane becoming visible.
    @e82eric
    e82eric committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    2fb7f8b View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. Bump codec version

    @e82eric
    e82eric committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    d5a0072 View commit details
    Browse the repository at this point in the history

  2. Update so that cli activate-pane will show/hide the floating pane when 

    the terminal window is not focused.
    @e82eric
    e82eric committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    2e83b11 View commit details
    Browse the repository at this point in the history

  3. Fix for cli list floating_pane.is_active always being true

    @e82eric
    e82eric committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    9cb6443 View commit details
    Browse the repository at this point in the history

  4. Revert "Update so that cli activate-pane will show/hide the floating … 

    …pane when"

This reverts commit 2e83b11.
    @e82eric
    e82eric committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    ab7acd6 View commit details
    Browse the repository at this point in the history

  5. Fix for activate-pane --pane-id (selecting non floating pane when 

    floating pane is active)
    @e82eric
    e82eric committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    c534829 View commit details
    Browse the repository at this point in the history

  6. Update so that cli activate-pane will show/hide the floating pane when 

    the terminal window is not focused
    @e82eric
    e82eric committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    7852213 View commit details
    Browse the repository at this point in the history