Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the issue #5348 and a typo #5362

Merged
merged 1 commit into from
May 5, 2024
Merged

Conversation

Kushagra2569
Copy link
Contributor

@Kushagra2569 Kushagra2569 commented May 2, 2024

Fixed #5348 for windows by setting margins check for window decoration for DwmExtendFrameIntoClientArea instead and using value -1 margin for only the TITLE style

Fixed the issue wez#5348 for windows by setting margins check for window decoration instead and using value 0 margin for only the TITLE style
@Taaqif
Copy link

Taaqif commented May 3, 2024

Keen on seeing this merged!

@wez
Copy link
Owner

wez commented May 4, 2024

Thanks for diving in! Could you run through the various combinations of title and system backdrop styles and verify that they all work correctly and/or share some screenshots of these?
I think the change you're proposing sounds plausible, but I'd it's not immediately obviously from the diff which combinations should result in which outcomes, and I don't currently have time to dig into this myself on a Windows machine.

Thanks!

@Kushagra2569
Copy link
Contributor Author

Kushagra2569 commented May 5, 2024

HI @wez , my bad , forgot to mention I did test before the pr and saw that only the TITLE decoration was having the issue where the acrylic was not being applied, and since TITLE by default has the windows buttons therefore it worked perfectly setting the margins for title to -1 while every other setting worked perfectly with these setting.
The Acrylic screenshots have the opacity set to 0.6 so the terminal looks as bit darker than the title bar
Essentially I have compared that all the settings looks exact same as without my change just without the bug
Tested on a Windows 11 machine
Adding the screenshots with my change as well
resize acrylic
resize disabled
title acrylic 0 6 opacity
title disable 0 6 opacity
title mica
title tabbed

@wez
Copy link
Owner

wez commented May 5, 2024

Thanks for confirming!

@wez wez merged commit d9455a4 into wez:main May 5, 2024
2 of 15 checks passed
wez added a commit that referenced this pull request May 5, 2024
saep pushed a commit to saep/wezterm that referenced this pull request Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants