Feature: add popup support #1059
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Understand that some of this is duplicative, but just roughing things in as I start to understand the architecture.
malkomalko
commented
Aug 21, 2021
| @@ -795,3 +811,64 @@ async fn domain_spawn_v2(spawn: SpawnV2, sender: PduSender) -> anyhow::Result<Pd | |||
| size: tab.get_size(), | |||
| })) | |||
| } | |||
|
|
|||
| async fn domain_spawn_popup(spawn_popup: SpawnPopup, sender: PduSender) -> anyhow::Result<Pdu> { | |||
There was a problem hiding this comment.
This is a copy and paste of domain_spawn above for the moment to get build working as I work my way through the understanding of this code. As I start implementation next of the cli command, this will change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Talked about in issue: #270
Keeping this as a WIP as I explore and push up how to make this happen.