-
-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrong window title/tab bar on macos, nightly #4966
Comments
I can't reproduce this. Is there more to your config file? |
No, that's the whole config file. It's only upon first launch, tab bar shows correctly after resizing the window or moving to external monitor. |
I didn't source and install the font you mentioned, because the |
Do you have other window management software installed that might adjust the size or layout of windows? |
Thanks, no window manger, but the font line is necessary for the issue to appear. |
There are a number of open issues that relate to getting the dpi wrong when spawning a window. In theory it shouldn't matter because we will immediately realize the difference and synthesize the correct information, but evidence shows this isn't quite true. What this commit does is: * Override Connection::default_dpi() on macOS to return the effective_dpi from the active screen instead of the default non-retina dpi * Adjust the Config::initial_size() method to accept an optional cell pixel dimension * Add a helper function to wezterm-gui to compute the cell pixel dimensions given the config and the (usually default) dpi, and feed that through to Config::initial_size * in the macos window impl, scale the computed geometry based on the ratio of the Connection::default_dpi and the default non-retina dpi. This helps to avoid needing to do a fixup in the #4966 case, and may help with the various other macos quirky issues. refs: #2958 refs: #3575 refs: #3900 refs: #4250 refs: #4285 refs: #4447 refs: #4851 refs: #4966
This should be resolved now in It typically takes about an hour before commits are available as nightly builds for all platforms. Linux builds are the fastest to build and are often available within about 20 minutes. Windows and macOS builds take a bit longer. Please take a few moments to try out the fix and let me know how that works out. You can find the nightly downloads for your system in the wezterm installation docs. If you prefer to use packages provided by your distribution or package manager of choice and don't want to replace that with a nightly download, keep in mind that you can download portable packages (eg: a If you are eager and can build from source then you may be able to try this out more quickly. |
Thanks for your hard work! Looks fixed in |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
What Operating System(s) are you seeing this problem on?
macOS
Which Wayland compositor or X11 Window manager(s) are you using?
No response
WezTerm version
20240205-070437-39d2b6ca aarch64-apple-darwin
Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?
Yes, and I updated the version box above to show the version of the nightly that I tried
Describe the bug
Launch wezterm with
window_decorations = "INTEGRATED_BUTTONS|RESIZE"
and a custom font, the window title bar/ tab bar would be incorrectly displayed, see below:To Reproduce
launch wezterm.app
Configuration
Expected Behavior
correct window title/tab bar
Logs
Debug Overlay
wezterm version: 20240205-070437-39d2b6ca aarch64-apple-darwin
Window Environment: macOS 14.3 (23D56)
Lua Version: Lua 5.4
OpenGL: Apple M1 Pro 4.1 Metal - 88
Enter lua statements or expressions and hit Enter.
Press ESC or CTRL-D to exit
15:31:49.028 INFO wezterm_gui::termwindow > QuitApplication over here (window)
Anything else?
No response
The text was updated successfully, but these errors were encountered: