Skip to content

Commit

Permalink
[FilterBox] Make filterbox localizable (apache#4466)
Browse files Browse the repository at this point in the history
* Make filterbox i18n

* Change double-quote to single-quote in localization function t() to pass
lint test

* Updated .po file with italian translation. New strings generated and translated via babel-extract
  • Loading branch information
raffas authored and mistercrunch committed Feb 25, 2018
1 parent 8c94a2f commit ef2d3de
Show file tree
Hide file tree
Showing 4 changed files with 2,146 additions and 1,031 deletions.
10 changes: 5 additions & 5 deletions superset/assets/visualizations/filter_box.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -111,17 +111,17 @@ class FilterBox extends React.Component {
<div className="col-lg-6 col-xs-12">
<DateFilterControl
name={since}
label="Since"
description="Select starting date"
label={t('Since')}
description={t('Select starting date')}
onChange={this.changeFilter.bind(this, since)}
value={this.state.selectedValues[since]}
/>
</div>
<div className="col-lg-6 col-xs-12">
<DateFilterControl
name={until}
label="Until"
description="Select end date"
label={t('Until')}
description={t('Select end date')}
onChange={this.changeFilter.bind(this, until)}
value={this.state.selectedValues[until]}
/>
Expand Down Expand Up @@ -227,7 +227,7 @@ class FilterBox extends React.Component {
onClick={this.clickApply.bind(this)}
disabled={!this.state.hasChanged}
>
Apply
{t('Apply')}
</Button>
}
</div>
Expand Down
2 changes: 1 addition & 1 deletion superset/translations/it/LC_MESSAGES/messages.json

Large diffs are not rendered by default.

Binary file modified superset/translations/it/LC_MESSAGES/messages.mo
Binary file not shown.
Loading

0 comments on commit ef2d3de

Please sign in to comment.