Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspaces working in dev #3863

Merged
merged 12 commits into from
Dec 11, 2018
Merged

workspaces working in dev #3863

merged 12 commits into from
Dec 11, 2018

Conversation

jamesgorrie
Copy link
Contributor

In an effort to get hooks working across all of our application, I hit the stumbling block of React not being the same instance of react on the client when rendering from commonvs catalogue|content.

FYI: facebook/react#13991

This made me think that we could probably get around this using workspaces.
Workspaces also make dependency management a bit nicer, it also remove the linkweco step, which is a bit odd.

It does however mean you need to run yarn from the root now, which slightly coupley, but the apps are coupled to common.

This did make me wonder if we had a ./apps folder with content, common, and content in. Thoughts? Could be adding layers for nothing, or nicely compartmentalised?

There was some Sass resolving issues, but as we're moving away from Sass, the hack felt fine.

@jamesgorrie jamesgorrie added the improvement ✨ A change made to an existing part of the product to try raise the baseline KPIs. label Dec 7, 2018
@jamesgorrie
Copy link
Contributor Author

I've done a test, and this now means the react us the same version, so we're back in action with hooks.

Copy link
Contributor

@gestchild gestchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be good to have a ./apps folder with the others inside

@jamesgorrie
Copy link
Contributor Author

jamesgorrie commented Dec 11, 2018

I think it might be good to have a ./apps folder with the others inside

Let's pair on that so we can see if it feels right.

Is there a reason, or just a feeling?

@jamesgorrie jamesgorrie merged commit c85ec62 into master Dec 11, 2018
@jamesgorrie jamesgorrie deleted the workspaces branch December 11, 2018 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement ✨ A change made to an existing part of the product to try raise the baseline KPIs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants