Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-install: wget2-wget has replaced wget #1370

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

AdamWill
Copy link
Contributor

wget has been retired:
https://src.fedoraproject.org/rpms/wget/c/ce69c17
in favor of wget2-wget:
https://fedoraproject.org/wiki/Changes/Wget2asWget

Signed-off-by: Adam Williamson <awilliam@redhat.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7672479880

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 43.472%

Totals Coverage Status
Change from base Build 7669211572: 0.0%
Covered Lines: 1616
Relevant Lines: 3504

💛 - Coveralls

@AdamWill
Copy link
Contributor Author

as this broke rawhide and bcl doesn't seem to be around rn, I'm doing a backport build so we can get a rawhide out.

@bcl
Copy link
Contributor

bcl commented Jan 27, 2024

Thanks for handling things. Why doesn't wget2-wget provide wget though? Seems like that's going to cause a whole bunch of confusion down the road.

@AdamWill
Copy link
Contributor Author

it does provide it, but IIRC, lorax needs exact binary package names, it can't find them via provides. comps is similar.

@bcl
Copy link
Contributor

bcl commented Jan 29, 2024

it does provide it, but IIRC, lorax needs exact binary package names, it can't find them via provides. comps is similar.

Lorax uses dnf to depsolve, it works fine with provides. Or should. Or did :) Maybe a dnf5 thing. I'm fine with the change, but I want to make sure there's not something else going on here first.

@AdamWill
Copy link
Contributor Author

oh, huh, then that's weird. This is the Rawhide compose failure we were dealing with: failed-composes issue, failed task, the actual failure. The backported patch did seem to fix it.

@bcl
Copy link
Contributor

bcl commented Jan 29, 2024

FTR I've filed #1372 to track this change in behavior.

Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@bcl bcl merged commit 9b703f5 into weldr:master Jan 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants