ltmpl: Pass packages to add_rpm_install as strings #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the discussion in: rpm-software-management/dnf5#1090 (comment) dnf5 handles NEVRA strings and package objects differently. So instead of passing in objects pass in the full NEVRA string. If a single install command has duplicates this won't matter, I already remove the dupes. But it should prevent problems where separate install commands end up selecting duplicate packages.
Pull Request Test Coverage Report for Build 7403261640
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the discussion in:
rpm-software-management/dnf5#1090 (comment)
dnf5 handles NEVRA strings and package objects differently. So instead of passing in objects pass in the full NEVRA string. If a single install command has duplicates this won't matter, I already remove the dupes. But it should prevent problems where separate install commands end up selecting duplicate packages.