Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command consul registry #96

Merged
merged 9 commits into from
Jun 21, 2016

Conversation

sunnights
Copy link
Collaborator

feat: 支持指令的consul注册中心
manager支持查看consul指令信息

@sunnights
Copy link
Collaborator Author

@qdaxb 功能已完成,请求merge

public boolean deleteCommand(String group, int index) {
RpcCommand remoteCommand = RpcCommandUtil.stringToCommand(getCommands(group));
if (remoteCommand == null) {
LoggerUtil.info("delete failed, command not found");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

日志里记录上下文

@qdaxb
Copy link
Collaborator

qdaxb commented Jun 14, 2016

SOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO many changes, I can't review.

@sunnights
Copy link
Collaborator Author

周一已经跟张雷对过流程了,得改些旧版本兼容问题,今天我再提交一下……

// service local cache. key: group, value: <service interface name, url list>
private ConcurrentHashMap<String, ConcurrentHashMap<String, List<URL>>> serviceCache = new ConcurrentHashMap<String, ConcurrentHashMap<String, List<URL>>>();
// command local cache. key: group, value: service interface name
private ConcurrentHashMap<String, String> commandCache = new ConcurrentHashMap<String, String>();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

描述跟使用不符,实际保存的指令吧?

}

@Test
public void testdoRegisterAndUnregister() {
public void doRegisterAndAvailable() throws Exception {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

添加一下测试多server注册、多client订阅同一个server、多client订阅同一个group等场景

@rayzhang0603 rayzhang0603 merged commit 9c3ac0a into weibocom:master Jun 21, 2016
@sunnights sunnights deleted the consul-command-registry branch December 24, 2018 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants