fix parsing multi directurl #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -157,7 +157,7 @@ public synchronized void initRef() { | |||
| durl.setHost(hostPort[0].trim()); | |||
| durl.setPort(Integer.parseInt(hostPort[1].trim())); | |||
| durl.addParameter(URLParamType.nodeType.getName(), MotanConstants.NODE_TYPE_SERVICE); | |||
| duBuf.append(StringTools.urlDecode(durl.toFullStr())).append(MotanConstants.COMMA_SEPARATOR); | |||
| duBuf.append(StringTools.urlEncode(durl.toFullStr())).append(MotanConstants.COMMA_SEPARATOR); | |||
There was a problem hiding this comment.
这里相当于以前会进行一次decode，现在会进行一次encode，一次decode，是否有可能出现以前正常，更新后少decode一次的情况？
There was a problem hiding this comment.
这个地方的encode、decode只在directurl方式下起作用，并且只在localregistry中保存，更新代码后不会出现问题
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1、解析directurl时，对refer参数进行urlencode，避免解析url错误。
2、扩展filter时可以不添加Activation注解。