Zookeeper graceful shutdown #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunnights
force-pushed
the
zookeeper-graceful-shutdown
branch
2 times, most recently
from
20053e2
to
fa1b81c
Compare
fix: 移除无用consul开关
sunnights
force-pushed
the
zookeeper-graceful-shutdown
branch
from
fa1b81c
to
e11b312
Compare
| for (URL u : getRegisteredServiceUrls()) { | ||
| String info = u.toFullStr(); | ||
|
|
||
| String unavaliabeServerNodePath = toUnavaliableServerNodePath(u); |
There was a problem hiding this comment.
available和unavailable做的内容是类似的，是否用参数区分，避免代码重复？
|
需要补充单元测试，并且评估一下服务上下线对zk集群性能的影响 |
| return nodeChildsToUrls(parentPath, currentChilds); | ||
| } catch (Throwable e) { | ||
| throw new MotanFrameworkException(String.format("Failed to discover %s from zookeeper(%s), cause: %s", url, getUrl(), e.getMessage())); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| protected void doAvailable(URL url) { | ||
| if (url == null) { |
There was a problem hiding this comment.
registeredServiceUrls有一个bug：
假如当前有3个unavailable url
当先调用available(url1)时，url1正常工作
再调用available(null)时，会再次重置url1
|
reference to #5 |
sunnights
force-pushed
the
zookeeper-graceful-shutdown
branch
from
9687017
to
9f1d1e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZooKeeper支持通过心跳开关来改变服务工作状态
修改相关文档