Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

experimental: add css custom properties support to advanced styles #4117

Merged
merged 1 commit into from
Sep 13, 2024
Merged

experimental: add css custom properties support to advanced styles #4117

merged 1 commit into from
Sep 13, 2024

Conversation

TrySound
Copy link
Member

Ref #3399

  • added custom properties autocomplete in advanced styles
  • fixed unit value detecting to not break var()
  • show inherited custom properties in advanced styles
  • dropped "types" from properties meta
  • parse not top level var(), for example inside layers or function as unparsed for now
image Screenshot 2024-09-12 at 21 53 38 Screenshot 2024-09-12 at 21 53 47

@TrySound
experimental: add css custom properties support to advanced styles
82a0359 
Ref #3399

- added custom properties autocomplete in advanced styles
- fixed unit value detecting to not break var()
- show inherited custom properties in advanced styles
- dropped "types" from properties meta
- parse not top level var(), for example inside layers or function as
  unparsed for now
@kof
Copy link
Member

kof commented Sep 13, 2024

just to make sure, this is allowed: var(--test) px ? because it works with 'width' and I am not sure why :)

image

@TrySound
Copy link
Member Author

Yeah, it's valid in browsers 🤷

@kof
Copy link
Member

kof commented Sep 13, 2024

  • when typing "var(" and going further with "var(--test" it would be good to still autocomplete, basically ignoring everything but the variable name, because when I have started typing var I won't get any completion and if I had a value inserted and now delete something - again I would expect it to auto complete

kof
kof approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found only the autocompletion issue, otherwise works well

@TrySound
Copy link
Member Author

Will improve autocomplete in separate PR

@TrySound TrySound merged commit c81b3d5 into main Sep 13, 2024
15 checks passed
@TrySound TrySound deleted the css-variables branch September 13, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kof kof kof approved these changes

@johnsicili johnsicili Awaiting requested review from johnsicili

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TrySound @kof