peer_connection: sdp: Fix BUNDLE group matching #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #583 +/- ##
==========================================
- Coverage 61.40% 61.36% -0.04%
==========================================
Files 533 533
Lines 49678 49679 +1
Branches 12619 12618 -1
==========================================
- Hits 30505 30487 -18
+ Misses 9855 9853 -2
- Partials 9318 9339 +21 ☔ View full report in Codecov by Sentry. |
rainliu
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor bug in my last PR allowed an empty BUNDLE group attribute from offer to add all unmatched results into answer. The correct answer should not have any BUNDLE group either of course.