Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add very simple test for version argument and use importlib feature instead of deprecated pkg_resources for version #173

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

white-gecko
Copy link
Contributor

Add very simple test for version argument and use importlib feature instead of deprecated pkg_resources for version.

Drop python 3.7 support (importlib.metadata) was introduced with python 3.8

Derived from #169 . Lets split it into portions.

@wumpus
Copy link
Collaborator

wumpus commented Aug 16, 2024

@tw4l should we care about Py 3.7? It was end of life last summer.

@wumpus
Copy link
Collaborator

wumpus commented Aug 17, 2024

@white-gecko would you mind adding 3.7 support by checking for ImportError? We have some examples of that elsewhere in this package, for example brotli support in warcio/bufferedreader.py

@white-gecko
Copy link
Contributor Author

Sure I could add it but thought, maybe its not worth it, if 3.7 could be droped all over. I will look into it on Monday.

@white-gecko
Copy link
Contributor Author

@white-gecko would you mind adding 3.7 support by checking for ImportError? We have some examples of that elsewhere in this package, for example brotli support in warcio/bufferedreader.py

I have added the requested change.

@wumpus wumpus merged commit 29da916 into webrecorder:master Aug 20, 2024
5 checks passed
@wumpus
Copy link
Collaborator

wumpus commented Aug 20, 2024

Thank you. The method to this madness is that this package is used in a lot of libraries by users on older python versions. Historically we've tried to make small adjustments to keep older versions still running.

At this point we can add py3.12 to the CI tests, and I've already verified that it and py3.13.0-rc.0 pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants