Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update development.md #4156

Closed
wants to merge 2 commits into from
Closed

Update development.md #4156

wants to merge 2 commits into from

Conversation

xp44mm
Copy link
Contributor

@xp44mm xp44mm commented Nov 12, 2020

os:windows

error: option '--open <value>' argument missing

describe your changes...

  • Read and sign the CLA. PRs that haven't signed it won't be accepted.
  • Make sure your PR complies with the writer's guide.
  • Review the diff carefully as sometimes this can reveal issues.
  • Do not abandon your Pull Request: Stale Pull Requests.
  • Remove these instructions from your PR as they are for your eyes only.

error: option '--open <value>' argument missing
@vercel
Copy link

vercel bot commented Nov 12, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/hvksrijl8
✅ Preview: https://webpack-js-org-git-patch-2.webpack-docs.vercel.app

@@ -274,7 +274,7 @@ __package.json__
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1",
"watch": "webpack --watch",
+ "start": "webpack serve --open",
+ "start": "webpack serve",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @evilebottnawi What do you think here? Shall we remove--open temporarily? It won't work until webpack-dev-server v4 is out according to webpack/webpack-cli#2001 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep --open, I will fix it in near future (2-3 days)

@@ -295,7 +295,7 @@ __package.json__
}
```

Now we can run `npm start` from the command line and we will see our browser automatically loading up our page. If you now change any of the source files and save them, the web server will automatically reload after the code has been compiled. Give it a try!
Now we can run `npm start --open` from the command line and we will see our browser automatically loading up our page. If you now change any of the source files and save them, the web server will automatically reload after the code has been compiled. Give it a try!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this as it doesn't fix the problem.

@chenxsan
Copy link
Member

Closing this as we would prefer keeping --open.

@chenxsan chenxsan closed this Nov 15, 2020
@xp44mm xp44mm deleted the patch-2 branch November 16, 2020 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants