-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(guides): update against webpack 5 #4099
docs(guides): update against webpack 5 #4099
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/dye45qavw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
I found It's very difficult to maintain those diff blocks, any suggestion? So far I've maintained a repository here https://github.com/chenxsan/webpack-demo and copy/paste those diff manually. Update
|
I'll continue this PR after it's fixed. |
@chenxsan Can you open an issue in |
} | ||
}; | ||
```diff | ||
const path = require('path'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is inverted, path
is the new line added.
console.log(json.title); // output `JSON5 Example` | ||
console.log(json.owner.name); // output `Tom Preston-Werner` | ||
```diff | ||
import Icon from './icon.png'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also inverted, Icon, Data and Notes are new lines.
@@ -26,28 +27,13 @@ Let's start by setting [`mode` to `'development'`](/configuration/mode/#mode-dev | |||
__webpack.config.js__ | |||
|
|||
``` diff | |||
const path = require('path'); | |||
const HtmlWebpackPlugin = require('html-webpack-plugin'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why removing it?
+ "watch": "webpack --watch", | ||
"build": "webpack" | ||
}, | ||
"repository": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to keep the entire diff.
I'm dropping this PR in favor of other smaller ones as this one will be a larger one making it difficult to review. |
closes #4090 fixes #4098
Guide
section needs to be updated against webpack 5, I'll do it in this pull request.PREVIEW URL: https://webpack-js-org-git-feature-update-guide-against-webpack5.webpack-docs.vercel.app/guides/getting-started/