Use internal-ip@4.0.0 #1668
Merged
Use internal-ip@4.0.0 #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internal-ip got an upgrade, as well as its dependency default-gateway. Both of them now support aix systems. Since internal-ip got a new major release version (because it was upgraded to use node>=6 as well), we need to upgrade the required version of internal-ip here.
patrickhrastnik
requested review from
alexander-akait and
michael-ciniawsky
as code owners
|
|
Codecov Report
@@ Coverage Diff @@
## master #1668 +/- ##
=======================================
Coverage 75.37% 75.37%
=======================================
Files 19 19
Lines 597 597
Branches 172 172
=======================================
Hits 450 450
Misses 113 113
Partials 34 34Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Feb 18, 2019
|
Thanks for merging the changes. When are they going to be released, to be available via npm? |
|
Today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Motivation / Use-Case
Short conclusion: This change makes webpack-dev-server available for AIX systems.
internal-ip got an upgrade, as well as its dependency default-gateway. Both of them now support aix systems. Since internal-ip got a new major release version (because it was upgraded to use node>=6 as well), we need to upgrade the required version of internal-ip here.
We have an AIX system we want to use Angular and/or React on. Since default-gateway was not available on AIX systems, we had to come up with a solution for this system.
The package maintainer of default-gateway politely made the pull request to update internal-ip. By doing this, they made a new major release. That's why the changes in default-gateway and internal-ip are not automatically used when installing webpack-dev-server.
Breaking Changes
Additional Info
default-gateway has a new optional dependency idb-connector. This is a package only available for AIX systems. Thus, it's listed in the package-lock.json, but not installed on other platforms. Optional dependencies don't lead to failure if they cannot be installed.