Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 4 compatibility #165

Closed
wants to merge 2 commits into from
Closed

Node 4 compatibility #165

wants to merge 2 commits into from

Conversation

jakeloo
Copy link

@jakeloo jakeloo commented Sep 27, 2015

Currently, sass-loader does not support Node 4 due to an issue of node-sass

However, Node 4 compatibility has been added in the release of v3.3.3

@jhnns
Copy link
Member

jhnns commented Sep 29, 2015

Thx for informing us.

But I don't think that we should merge this. It forces all users, who are not using node 4, to update their peerDependency. On the other hand, node 4 users are able to specify node-sass^3.3.3 as dependency and still use the current sass-loader, aren't they?

@jhnns
Copy link
Member

jhnns commented Sep 30, 2015

Shipped as breaking change with sass-loader 3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants