Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize paths of dependencies #141

Merged
merged 2 commits into from
Aug 14, 2015
Merged

Conversation

strayiker
Copy link

This fixes bug where webpack ignores the incremental build and recompile all files in project (win 8.1)

@@ -237,7 +237,7 @@ module.exports = function (content) {
return result.css.toString();
} catch (err) {
formatSassError(err);
err.file && this.dependency(err.file);
err.file && addNormalizedDependency(err.file);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that this is necessary. formatSassError is already normalizing it.

@jhnns
Copy link
Member

jhnns commented Aug 10, 2015

Could you give me an example where the problem occurs? The paths are already normalized afaik.

@strayiker
Copy link
Author

jhnns added a commit that referenced this pull request Aug 14, 2015
Normalize paths of dependencies
@jhnns jhnns merged commit 7bab632 into webpack-contrib:master Aug 14, 2015
jhnns added a commit that referenced this pull request Aug 14, 2015
@jhnns
Copy link
Member

jhnns commented Aug 14, 2015

Shipped with 2.0.1. Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants