Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change function arguments of the import option #1124

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

alexander-akait
Copy link
Member

BREAKING CHANGE: function arguments of the import option were changed, it is now funciton(url, media, resourcePath) {}

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

For DX

Breaking Changes

Yes

Additional Info

No

BREAKING CHANGE: function arguments of the `import` option were changed, it is now `funciton(url, media, resourcePath) {}`
@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #1124 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1124   +/-   ##
=======================================
  Coverage   99.50%   99.50%           
=======================================
  Files          10       10           
  Lines         605      605           
  Branches      186      186           
=======================================
  Hits          602      602           
  Misses          3        3           
Impacted Files Coverage Δ
src/plugins/postcss-import-parser.js 100.00% <100.00%> (ø)
src/utils.js 98.76% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c153fe6...edc8086. Read the comment docs.

@alexander-akait alexander-akait merged commit 01e8c76 into master Jul 22, 2020
@alexander-akait alexander-akait deleted the refactor-import-as-function branch July 22, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant