Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add lifecycle event docs for Page Builder - Block V2 #476

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

neatbyte-vnobis
Copy link

@neatbyte-vnobis neatbyte-vnobis commented May 18, 2022

Short Description

Add new Page Builder lifecycle events for Block Categories.

Relevant Links

  • A change on /docs/page-builder/references/lifecycle-events page

Checklist

  • I checked for typos and grammar mistakes

@vercel
Copy link

vercel bot commented May 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs-webiny-com ✅ Ready (Inspect) Visit Preview Jun 22, 2022 at 1:54PM (UTC)

@adrians5j
Copy link
Member

adrians5j commented May 20, 2022

Hey @neatbyte-vnobis , I checked the changes. All in all looking good, just a couple of consistency-related comments:

image

  1. Please start with lower case, as it is the case with the rest of the menu items.
  2. Please remove TopicParams suffix, as it is he case with the rest of the menu items.

Other than than, it looks good, and I'm sure we'll be able to merge this once we resolve the above.

Thank you!

@neatbyte-vnobis neatbyte-vnobis changed the title docs: add new Page Builder lifecycle events for Block Categories docs: add lifecycle event docs for Page Builder - Block V2 Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants