Adds a basic function check for GetStats #4499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a skeleton that can be extended for any number of tests. It passes on Chrome Canary with the "experimental features" flag set.
|
Notifying @alvestrand, @dontcallmedom, and @phoglund. (Learn how reviewing works.) |
|
@henbos please take a look - it seems like an easy way to check on Firefox compatibility. |
This allows much more interesting tests to be written, since more of the stats are populated.
henbos
approved these changes
Jan 9, 2017
| let sessionStat = getStatsRecordByType(report, 'peer-connection'); | ||
| assert_not_equals(sessionStat, null, 'Did not find peer-connection stats'); | ||
| assert_exists(sessionStat, 'dataChannelsOpened'); | ||
| assert_equals(sessionStat.dataChannelsOpened, 1); |
There was a problem hiding this comment.
nit: Wouldn't it make more sense to call sessionStats peerConnectionStats?
| if (gFirstConnection.iceConnectionState != 'connected') { | ||
| return; | ||
| } | ||
| gFirstConnection.getStats() |
There was a problem hiding this comment.
A follow-up CL should add one using the selector argument, though that would require tracks.
| assert_not_equals(report, null); | ||
| let sessionStat = getStatsRecordByType(report, 'peer-connection'); | ||
| assert_not_equals(sessionStat, null, 'Did not find peer-connection stats'); | ||
| assert_exists(sessionStat, 'dataChannelsOpened'); |
There was a problem hiding this comment.
(Sweet, this does not have to be updated even if w3c/webrtc-stats#125 lands.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a skeleton that can be extended for any number of tests.
It passes on Chrome Canary with the "experimental features" flag set.
This change is