Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

ignited: allow running help, completion, version subcommands without root permission #955

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

folliehiyuki
Copy link

This is pretty much a copy and paste of #676 but for ignited command.

I also did some minor extra things:

  • Move all GenericCheckErr calls from to PersistentPreRun stage of cobra. A couple of them are already there to begin with (this specially helps ignited command as Preload checks for MANIFEST_DIR and fails).
  • Remove TODO statement on isNonRootCommand() function (we already handle each subcommands).
  • Fix typo??? in populating ignited provider (it was ignite).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant