Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Fix vm stop-start with default providers #735

Merged

Conversation

darkowlzz
Copy link
Contributor

When a running VM is stopped, the runtime and network info are removed
from the VM object status. Starting the VM without any explicit provider
flags fails due to lack of provider info.

$ sudo ./bin/ignite run weaveworks/ignite-ubuntu --name my-vm --ssh
...
INFO[0019] Started Firecracker VM "97eddf8562c22d03" in a container with ID "ignite-97eddf8562c22d03"
INFO[0020] Waiting for the ssh daemon within the VM to start...
$ sudo ./bin/ignite stop my-vm
INFO[0000] Removing the container with ID "ignite-97eddf8562c22d03" from the "cni" network
INFO[0001] Stopped VM with name "my-vm" and ID "97eddf8562c22d03"
$ sudo ./bin/ignite start my-vm
FATA[0000] unknown runtime ""

This change adds the default providers in the VM status if the runtime
and network are empty when attempting to start the VM. Any explicitly
passed provider flags continue to override the VM providers.

Also, adds an e2e test to verify the fix.

@darkowlzz darkowlzz added the kind/bug Categorizes issue or PR as related to a bug. label Nov 22, 2020
When a running VM is stopped, the runtime and network info are removed
from the VM object status. Starting the VM without any explicit provider
flags fails due to lack of provider info.
This change adds the default providers in the VM status if the runtime
and network are empty when attempting to start the VM. Any explicitly
passed provider flags continue to override the VM providers.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants