Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Fix CNI portmapping cleanup #691

Merged
merged 6 commits into from
Sep 21, 2020
Merged

Fix CNI portmapping cleanup #691

merged 6 commits into from
Sep 21, 2020

Conversation

networkop
Copy link
Contributor

Fixes #690

@networkop networkop mentioned this pull request Sep 16, 2020
Closed
@darkowlzz darkowlzz added the area/networking Issues related to networking label Sep 21, 2020
darkowlzz
darkowlzz approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and an e2e test that verifies the fix.
LGTM!

@stealthybox
Copy link
Contributor

Thanks so much for digging into this -- patch looks great
Sorry about the test flakes :)

@stealthybox stealthybox merged commit 01a2838 into weaveworks:master Sep 21, 2020
@stealthybox stealthybox added the kind/bug Categorizes issue or PR as related to a bug. label Nov 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@darkowlzz darkowlzz darkowlzz approved these changes

@twelho twelho Awaiting requested review from twelho

Assignees
No one assigned
Labels
area/networking Issues related to networking kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ignite CNI leaves stale portmappings
3 participants
@networkop @stealthybox @darkowlzz