Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

add simple CODEOWNERS file #331

Merged
merged 1 commit into from
Aug 13, 2019
Merged

add simple CODEOWNERS file #331

merged 1 commit into from
Aug 13, 2019

Conversation

dholbach
Copy link
Contributor

@dholbach dholbach commented Aug 13, 2019 •
edited by luxas
Loading

Here Dennis and Lucas are both added for all areas of the code.
Fixes: #328

@dholbach
Copy link
Contributor Author

(It's what we went with for Scope too: https://github.com/weaveworks/scope/blob/master/.github/CODEOWNERS)

luxas
luxas approved these changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
LGTM 👍

@luxas luxas self-assigned this Aug 13, 2019
@luxas luxas added the kind/documentation Categorizes issue or PR as related to documentation. label Aug 13, 2019
@luxas luxas added this to the v0.5.0 milestone Aug 13, 2019
@luxas luxas merged commit 29a3f5a into weaveworks:master Aug 13, 2019
@dholbach dholbach deleted the fix-328 branch August 13, 2019 20:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@luxas luxas luxas approved these changes

Assignees

@luxas luxas

Labels
kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

Use Github code-owners
2 participants
@dholbach @luxas