This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Add .status.runtime.id the VM container's ID
#294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twelho
added
kind/api-change
luxas
approved these changes
Aug 8, 2019
| @@ -107,6 +107,9 @@ func StartVM(vm *api.VM, debug bool) error { | |||
| return fmt.Errorf("failed to start container for VM %q: %v", vm.GetUID(), err) | |||
| } | |||
|
|
|||
| // Set the container ID for the VM | |||
| vm.Status.Runtime = &api.Runtime{ID: containerID} | |||
There was a problem hiding this comment.
We'll decide on some conventions here, but probably we'll follow Kubernetes' style docker://abcdef...
| } | ||
|
|
||
| // TODO: Enable this when ignite-spawn doesn't write to the file anymore | ||
| //if err := providers.Client.VMs().Set(vm); err != nil { |
There was a problem hiding this comment.
Cool, this needs to wait for later 👍
luxas
changed the title
runtime.id for tracking the VM container's ID.status.runtime.id for tracking the VM container's ID
luxas
changed the title
.status.runtime.id for tracking the VM container's ID.status.runtime.id the VM container's ID
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not enabled for now,
ignite-spawnneeds to stop writing to the VM metadata on startup. This PR is part of the API changes for v0.5.0.cc @luxas
Fixes: #210