Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Replace vm.status.state with vm.status.running #292

Merged
merged 4 commits into from
Aug 8, 2019
Merged

Replace vm.status.state with vm.status.running #292

merged 4 commits into from
Aug 8, 2019

Conversation

twelho
Copy link
Contributor

@twelho twelho commented Aug 8, 2019 •
edited by luxas
Loading

Eliminates the old VMStatusCreated, it is now handled on-demand. This PR is part of the API changes for v0.5.0.

cc @luxas

Fixes: #293

@twelho twelho added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/design Categorizes issue or PR as related to the design of the project. labels Aug 8, 2019
@twelho twelho added this to the v0.5.0 milestone Aug 8, 2019
luxas
luxas approved these changes Aug 8, 2019
View reviewed changes
Copy link
Contributor

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Nice and clean change. Always nice to remove more LoC than you add 😉

@luxas luxas merged commit 0657c0c into weaveworks:master Aug 8, 2019
@twelho twelho deleted the state-change branch August 8, 2019 10:48
@luxas luxas mentioned this pull request Aug 8, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@luxas luxas luxas approved these changes

Assignees

@luxas luxas

Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/design Categorizes issue or PR as related to the design of the project.
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

Simplify .status.state into .status.running
2 participants
@twelho @luxas