Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

first circleci test #277

Merged
merged 2 commits into from
Aug 5, 2019
Merged

first circleci test #277

merged 2 commits into from
Aug 5, 2019

Conversation

luxas
Copy link
Contributor

@luxas luxas commented Aug 5, 2019

I think that something like this may do it, but I've never used Circle before so ¯_(ツ)_/¯

Partly fixes: #71

@luxas luxas added this to the v0.5.0 milestone Aug 5, 2019
@luxas
Copy link
Contributor Author

luxas commented Aug 5, 2019

The build passes 🎉!
That's enough for today. Tomorrow I'll look into getting the tests running in CI too

@luxas luxas merged commit 1e228d9 into master Aug 5, 2019
@aojea
Copy link
Contributor

aojea commented Aug 6, 2019

@luxas don´t you implement a workflow?
let me know if you need help with this, I have some experience with circleCI

@aojea
Copy link
Contributor

aojea commented Aug 6, 2019

scratch it, I see that this is WIP https://github.com/weaveworks/ignite/pull/280/files, sorry for the noise 😅

@luxas
Copy link
Contributor Author

luxas commented Aug 6, 2019

I'll fix up some stuff in #280, but I'd definitely appreciate help with the rest that I won't fix in #280 (e.g. import-boss stuff #260 and/or golang-ci-lint). Thanks 👏!

@luxas luxas added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 6, 2019
@luxas luxas deleted the circleci branch August 6, 2019 18:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI integration tests
2 participants