This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Client and Storage rework: Recognize multiple API groups #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meta.Kind. Also add a .New method
…e client, too. Make the client GroupVersion-aware
…ializer, and set the gvk in Storage.decode
luxas
added
kind/refactor
twelho
reviewed
Jul 19, 2019
| log "github.com/sirupsen/logrus" | ||
| api "github.com/weaveworks/ignite/pkg/apis/ignite" | ||
| meta "github.com/weaveworks/ignite/pkg/apis/meta/v1alpha1" | ||
| "github.com/weaveworks/ignite/pkg/storage" | ||
| "github.com/weaveworks/ignite/pkg/storage/filterer" | ||
|
|
| log "github.com/sirupsen/logrus" | ||
| api "github.com/weaveworks/ignite/pkg/apis/ignite" | ||
| meta "github.com/weaveworks/ignite/pkg/apis/meta/v1alpha1" | ||
| "github.com/weaveworks/ignite/pkg/storage" | ||
| "github.com/weaveworks/ignite/pkg/storage/filterer" | ||
|
|
There was a problem hiding this comment.
Rerun make tidy after removing the blank line from template
| meta "github.com/weaveworks/ignite/pkg/apis/meta/v1alpha1" | ||
|
|
| @@ -5,6 +5,8 @@ import ( | |||
|
|
|||
| meta "github.com/weaveworks/ignite/pkg/apis/meta/v1alpha1" | |||
| "github.com/weaveworks/ignite/pkg/storage" | |||
|
|
|||
|
The blank lines are rebase conflict. I'll fixup those in this follow up: #224 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, the client and storage framework was locked in to only one particular combination of
apiVersion, or in other words,GroupVersion. We only checkedmeta.Kindeverywhere; but that always implicitly assumed that the GroupVersion was ignite/v1alpha1Fixes: #199
This PR:
Storage(Cache), andFiltererinterfaces operate onschema.GroupVersionKind, notmeta.KindClientstruct to a gv-specificIgniteInternalClient, and passes through the GVK automatically to the storage as a consequence.Client.New->Storage.Newmethod being the canonical way to create a new API object. In other words, do not do&api.VM{}or similar anymore.