Replace nullable_visit by NullableVisitor #86
Conversation
phorward
changed the title
This introduces the NullableVisitor from CPython's pegen.
phorward
force-pushed
the
cpython-to-pegen_nullables
branch
from
760638e
to
4a7bb97
Compare
|
@phorward please don't force push after an approval because it forces us to dismiss the review and review again everything :) |
I'm sorry, I did only correct the commit message, as it was wrong. |
|
Hello @pablogsal, I hope you're doing well. Can you please take another review and maybe merge on this pull request? I've started to work on a pull request setting-up on this one, to successively transfer all overrides from the CPython version of pegen to the stand-alone project. It is important for me to have the stand-alone pegen in similar code-base as the CPython version, to start with further developments on it. I would like to share my vision of pegen in some kind, if interested, as it may become a universal PEG-like parser generator not only limited to Python. Please contact me, or provide a way to share ideas. |
|
@phorward Thanks for the PR and sorry for taking so long on this. We've been very busy with other things and this fell further down in our list of to-dos. If you want to start a discussion on ideas you have for the project, an issue would be the best way forward. Please open one, and I'd be happy to get a conversation going there. |
No problem, thanks for merging. Can you please check the GitHub action job that is currently pending, so that the merge becomes complete?
Ok thanks. I wrote some ideas down on a vision for pegen in my fork anypeg, but I think it'll be the best to divide it into separate issues to easier maintain and focus on. |
This introduces the NullableVisitor from CPython's pegen.
This is part of the former PR #85.
I was able to run the test-suite locally, using pipenv and python38.
Generally, should we not upgrade to latest python310 with all pegen development?