Stop creating unused variables

[0dminnimda]

No description provided.

[0dminnimda]

Is it reasonable to first try to merge it to cpython?

[pablogsal]

Is it reasonable to first try to merge it to cpython?

Generally we do it the other way: we merge stuff here and I sync them from time to time in batches.

[0dminnimda]

Ok, I see.
Also can I ask you for the launch of the workflow, please?

[0dminnimda]

Probably a good time to say, that two tests are failing on the main. The same tests are failing here. Although I think fixing those tests is out of the scope of this pr, unfortunately

[MatthieuDartiailh]

Getting #66 in first would make sense to get CIs to test on more versions.

[0dminnimda]

Does #66 fixes broken tests? If yes, then we probably should try merging those fixes first independently of the #66.

[0dminnimda]

Generally we do it the other way: we merge stuff here and I sync them from time to time in batches

Well, then what's about distributing credit/blame for the changes? Will those changes be cherry-picked into cpython?

[pablogsal]

Generally we do it the other way: we merge stuff here and I sync them from time to time in batches

Well, then what's about distributing credit/blame for the changes? Will those changes be cherry-picked into cpython?

No, they will be directly included in one batch and blame/credit is lost.

[0dminnimda]

No, they will be directly included in one batch and blame/credit is lost.

Aww, isn't this a reason to make a direct pr to cpython?

Well, not like it's that important, but it would be nice if the credit/blame was preserved!

[pablogsal]

Aww, isn't this a reason to make a direct pr to cpython?

No, we don't generally merge individual PRs in CPython for pegen because it makes syncing much more complicated.

Well, not like it's that important, but it would be nice if the credit/blame was preserved!

Well, the canonical code for pegen is here. The CPython version doesn't match this code because it has a bunch of Cpython-isms and the C generator which is is own beast. Notice that the only python parser being generated in CPython is the grammar parser, but the main output is the C version.

[MatthieuDartiailh]

@0dminnimda Can you rebase on main so that we get an extended test run ?

[0dminnimda]

Oh yeah, workflow activation, what a lovely github feature ♥

[gvanrossum]

Bye, I am leaving this repo now.

[0dminnimda]

oh .. bye

well, we need to get back to the work

3.10 didn't pass, it seems like versoin of python that tox runs is somehow different from the other ones
Because if I try replicate this I see a string without '

I don't quite understand why it happens

[MatthieuDartiailh]

#71 will fix the failure on 3.10 (3.10.5 fixed an issue for which we had a workaround)

[0dminnimda]

Closing and opening to triger the ci

[0dminnimda]

oh yeah, forgot to merge

[0dminnimda]

Is there any additional comments or this can be merged?

[MatthieuDartiailh]

I found one concerning issue regarding cut (and I find even more concerning that no test found the issue). I also left a couple of comment/question.

[0dminnimda]

I find even more concerning that no test found the issue

Should I add the tests for it here? Tho seems appropriate for another pr

[0dminnimda]

Maybe @pablogsal have other comments?

[pablogsal]

Maybe @pablogsal have other comments?

I will try to review this soon but currently, I am very busy with the 3.11.0b5 release :(

[MatthieuDartiailh]

I left a minor suggestions for improvement and a question otherwise LGTM.

[0dminnimda]

@MatthieuDartiailh can you allow the workflow?

[MatthieuDartiailh]

Done

[MatthieuDartiailh]

@pablogsal would you have time to look at this ? or do you want to defer the final review to me maybe (since you seem quite busy ATM).

[pablogsal]

@pablogsal would you have time to look at this ? or do you want to defer the final review to me maybe (since you seem quite busy ATM).

I apologize for the late reply @MatthieuDartiailh. Unfortunately the release of 3.11 is being ridiculously challenging and I'm expending all my OSS time on that :(

Please, go ahead and merge it if you feel confident. I trust your criteria 👍

[MatthieuDartiailh]

I wanted to add a couple small comments but apparently I cannot push to your repo. S I will merge and add the comment directly on main.

[0dminnimda]

Weird usually there's no problem in that
Maybe i accidentally checked out Allow edits by maintainers..