Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S3 plugin installation in Elasticsearch #293

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Fix S3 plugin installation in Elasticsearch #293

merged 1 commit into from
Jan 15, 2020

Conversation

AnthonySendra
Copy link
Contributor

@AnthonySendra AnthonySendra commented Jan 10, 2020 •
edited
Loading

Hello,

This PR fixes two problems I had with the installation of the S3 plugin.

  • The first one is related to ARG before FROM which is not taken into account in the rest of the Dockerfile.
  • The second one was related to ${bin/elasticsearch-plugin install --batch S3_PLUGIN_URL} which did nothing

@AnthonySendra AnthonySendra changed the title Fix s3 plugin Fix S3 plugin installation in Elasticsearch Jan 10, 2020
@manuasir
Copy link
Contributor

Thanks for collaborating @AnthonySendra, we'll take a look at this so it can be shipped ASAP.

@manuasir manuasir requested a review from xr09 January 13, 2020 17:24
xr09
xr09 approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@xr09 xr09 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @AnthonySendra !

@manuasir manuasir changed the base branch from master to devel January 15, 2020 14:11
@manuasir manuasir merged commit 4b054e8 into wazuh:devel Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xr09 xr09 xr09 approved these changes

@manuasir manuasir manuasir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AnthonySendra @manuasir @xr09