Image view now shows the correct image when the cell is reused #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jay18001
suggested changes
Aug 23, 2017
Tests/Bricks/ImageBrickTests.swift
Outdated
| } | ||
|
|
||
|
|
||
|
|
| override open func prepareForReuse() { | ||
| super.prepareForReuse() | ||
| imageView.image = nil | ||
| currentImageURL = nil |
There was a problem hiding this comment.
I think imageLoaded and currentImageURL need to be reset too
There was a problem hiding this comment.
Updated to add in imageLoaded as well
logannathanson
force-pushed
the
verticals/10951009/Reset-Image-Before-Reuse
branch
5 times, most recently
from
c7ee9ab
to
034389f
Compare
logannathanson
force-pushed
the
verticals/10951009/Reset-Image-Before-Reuse
branch
from
034389f
to
035ca8b
Compare
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
==========================================
+ Coverage 93.45% 93.46% +<.01%
==========================================
Files 40 40
Lines 4247 4253 +6
Branches 348 348
==========================================
+ Hits 3969 3975 +6
Misses 277 277
Partials 1 1
Continue to review full report at Codecov.
|
jay18001
approved these changes
Aug 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that causes an image brick cell to not properly reset before reusing it.