Adds the ability to use the collectionView delegate function willDisp… #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lay cell on the brickCell
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
=========================================
Coverage ? 93.41%
=========================================
Files ? 39
Lines ? 3159
Branches ? 0
=========================================
Hits ? 2951
Misses ? 208
Partials ? 0
Continue to review full report at Codecov.
|
rubencagnie
suggested changes
Jul 12, 2017
| } | ||
| } | ||
|
|
||
| override open func willDisplay() { |
There was a problem hiding this comment.
I'd like to see if "apply(layoutAttributes" would do the trick instead. Then you don't rely on a delegate
| cell = brickViewController.brickCollectionView.cellForItem(at: IndexPath(item: 0, section: 1)) as? DummyBrickCell | ||
| XCTAssertEqualWithAccuracy(cell?.frame.width ?? 0, width / 5, accuracy: 0.1) | ||
| XCTAssertEqualWithAccuracy(cell?.frame.height ?? 0 , (width / 5) * 2, accuracy: 0.1) | ||
| XCTAssertTrue(cell.didCallUpdateContent) |
There was a problem hiding this comment.
We should add a test to verify that the image has the correct width as that's the issue. We could make a subclass of ImageBrick to verify this...
|
This functionally was done with #161 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lay cell on the brickCell
--This is being added so we know the imageView size before getting the url.
--Updated Tests