MONIT-40224: ebpfSampler #861
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why Java CI build failed. On my local, it has been successful. |
oppegard
reviewed
Jul 19, 2023
Comment on lines
28
to
29
| private static final String OTEL_SCOPE_KEY = "otel.scope.name"; | ||
| private static final String OTEL_SCOPE_VALUE_PIXIE = "pixie"; |
There was a problem hiding this comment.
The span tag to identify auto-instrumentation/ebpf data has changed to origin, and the value will be opapps-auto.
@xuranchen added an origin constant to the Java SDK that's available in v3.2.0+. This is where we're setting the span tag in the PxL script: https://github.com/wavefrontHQ/observability-for-kubernetes/blob/4f3f644f59e2b8dfd9e94feca020e5fe9cbdd716/operator/hack/autoinstrumentation/spans.pxl#L171
xuranchen
reviewed
Jul 19, 2023
| .collect(Collectors.toMap(Annotation::getKey, Annotation::getValue)); | ||
| } | ||
|
|
||
| private CacheKey extractCachKey(@Nonnull Span span, @Nonnull Map<String, String> annotationMap) { |
xuranchen
reviewed
Jul 19, 2023
| import wavefront.report.Span; | ||
|
|
||
| public interface PreferedSampler { | ||
| boolean sample(@Nonnull Span span); |
There was a problem hiding this comment.
Could you add some comments describing the functionality of the interface and its functions
xuranchen
approved these changes
Jul 25, 2023
oppegard
approved these changes
Aug 1, 2023
|
Note: @zen10001 to change base branch to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for a New Sampling Strategy for eBPF traffic. The design doc is here https://confluence.eng.vmware.com/pages/viewpage.action?spaceKey=WFENG&title=Design+Doc+for+a+New+Sampling+Strategy+for+eBPF+traffic
There are two more tickets related to this
MONIT-40225 | Configuration and parameter tuning of ebpfSampler
MONIT-40444 | ebpf script change for eBPF sampler