Update functions to Async/Await #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdelfino
requested changes
Sep 11, 2017
src/app.js
Outdated
| id | ||
| // Return a list of spaces the app belongs to | ||
| const spaces = (tok) => { | ||
| return new Promise((resolve, reject) => { |
There was a problem hiding this comment.
I'd suggest to convert this to use the async keyword (vs explicitly returning a Promise) and convert the asynchronous calls inside this function to use await (as this pull request seems to be about converting the sample async/await), instead of having a mix of async/await and promise programming models.
src/app.js
Outdated
| 'https://api.watsonwork.ibm.com/v1/spaces/' + spaceId + '/messages', { | ||
| headers: { | ||
| Authorization: 'Bearer ' + tok | ||
| const token = (appId, secret) => { |
There was a problem hiding this comment.
Same comment as above, suggesting to convert to async/await as well.
src/app.js
Outdated
| }; | ||
|
|
||
|
|
||
| // Send an app message to the conversation in a space | ||
| const send = (spaceId, text, tok) => { |
There was a problem hiding this comment.
Suggesting to convert to async/await here as well.
src/app.js
Outdated
| @@ -149,5 +139,4 @@ if(require.main === module) | |||
| (err) => { | |||
| if(err) | |||
| console.log('Error sending message:', err); | |||
| }); | |||
|
|
|||
| }); | |||
There was a problem hiding this comment.
Not sure what that last character at the bottom of the file is.
Description: Promisify post from request module, Convert callback style functions to implement async/await Remove done flag from unit test and check function Make unit test async/await
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Sebastian,
Yay, my first pull request! I "promisified" the api helper functions and converted main function to use async/await.
fingers crossed.