ELEX-3298 experiment with dropping units whose turnout factors are outliers #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion; works but unit tests failing
…nto ELEX-3298-experiment-with-dropping-units-whose-turnout-factors-are-outliers
…r() unit test to remind myself why the mean and std are being computed twice
…nto ELEX-3298-experiment-with-dropping-units-whose-turnout-factors-are-outliers
…nto ELEX-3298-experiment-with-dropping-units-whose-turnout-factors-are-outliers
…nto ELEX-3298-experiment-with-dropping-units-whose-turnout-factors-are-outliers
…nto ELEX-3298-experiment-with-dropping-units-whose-turnout-factors-are-outliers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi! The changes in this PR remove the
turnout_factor_lowerandturnout_factor_upperthresholds in favor of outlier detection. The mean and standard deviation ofturnout_factoris determined per state then used to identify outliers via the mean ± (standard deviation * 4.75). Thiszhas been selected so as to minimize the changes to the unit test results, race call times, and predictions. See the notebook here for more details on performance evaluation against the 2022 US Senate GE 🎉 Thanks!!Jira Ticket
ELEX-3298
Test Steps
tox,elexmodelcommands with non-modeled units, test bed, etc.