Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint and "lint" npm scripts #20

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

eheikes
Copy link
Contributor

@eheikes eheikes commented Nov 4, 2019

Adds linting to the project (for the client and server packages) using ESLint and lint npm scripts. It does both traditional linting (looking for problematic patterns) and style checking (enforcement of conventions). The rules were selected to match the existing code as closely as possible.

Run lerna run lint to test it out.

@djhi
Copy link

djhi commented Nov 14, 2019

Thanks but I'd rather have prettier handle the formatting itself by adding eslint-prettier-config and eslint-prettier-plugin

@eheikes
Copy link
Contributor Author

eheikes commented Nov 18, 2019

Okay, I added the Prettier plugins and use them to format the code.

Copy link

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants