Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update user prompt handler note for fallbackDefault #1831

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Update user prompt handler note for fallbackDefault #1831

merged 2 commits into from
Jul 23, 2024

Conversation

juliandescottes
Copy link
Contributor

@juliandescottes juliandescottes commented Jul 16, 2024 •
edited by pr-preview bot
Loading

  • Update the note to reflect the fact that "default" now applies to before unload and mention fallbackDefault
  • fix get the prompt handler to select fallbackDefault when relevant

Preview | Diff

@juliandescottes
Copy link
Contributor Author

cc @jgraham

jgraham
jgraham requested changes Jul 19, 2024
View reviewed changes
index.html Outdated Show resolved Hide resolved
@juliandescottes @jgraham
Update index.html
6058d03 
Co-authored-by: jgraham <james@hoppipolla.co.uk>
@jgraham jgraham merged commit 7a23ea0 into w3c:master Jul 23, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Jul 23, 2024
@juliandescottes @github-actions
Update user prompt handler note for fallbackDefault (#1831)
d1026c7 
SHA: 7a23ea0
Reason: push, by jgraham

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to soloinovator/webdriver that referenced this pull request Aug 22, 2024
@juliandescottes @github-actions
Update user prompt handler note for fallbackDefault (w3c#1831)
1af95d4 
SHA: 7a23ea0
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to xjc90s/webdriver that referenced this pull request Aug 22, 2024
@juliandescottes @github-actions
Update user prompt handler note for fallbackDefault (w3c#1831)
0d2e928 
SHA: 7a23ea0
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to ZRDKPoWeR/webdriver that referenced this pull request Aug 23, 2024
@juliandescottes @github-actions
Update user prompt handler note for fallbackDefault (w3c#1831)
5bcd3e3 
SHA: 7a23ea0
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgraham jgraham jgraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliandescottes @jgraham