-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WCG color spaces. #566
Conversation
"iec61966-2-1", | ||
"linear", | ||
"pq", | ||
"hlg", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alternative names here are "smpte2084" and "arib-std-b67", which would align with FFmpeg naming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK as is, but if you're considering changing, I'd suggest referencing BT2100, so something like bt2100-2-pq
and bt2100-2-hlg
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that more legible? Even Wikipedia just calls it PQ/HLG.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clarify, my preference is for pq
and hlg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah great :) I think Dan was just playing devils advocate above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see! My comment was really: if you're going in that direction, prefer BT.2100 rather than the SMPTE and ARIB standards.
Should we align these with Media Capabilities ColorGamut and TransferFunction? Are there cases where WebCodecs needs a different set of possible values than Media Capabilities? |
The short answer is that we diverged with the first version of WebCodecs, which we decided was acceptable since WebCodecs does not integrate with MediaCapabilities. Some of the values I picked in this PR do match between the two, at least. Perhaps more relevant is alignment with https://github.com/w3c/ColorWeb-CG/blob/master/hdr_html_canvas_element.md, but that is not yet finalized and also has a different technical interpretation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Names lgtm since we're using what's named in H.273.
Any last comments on these names? It's been 3 weeks, so we'll go ahead and merge tomorrow otherwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dalecurtis, sorry for the delay. I left one minor comment to consider, but otherwise looks good.
Thanks all. I think we have sufficient approval to merge now. |
SHA: 34b6ed2 Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 34b6ed2 Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 34b6ed2 Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 34b6ed2 Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 34b6ed2 Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 34b6ed2 Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 34b6ed2 Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 34b6ed2 Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 34b6ed2 Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 34b6ed2 Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 34b6ed2 Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 34b6ed2 Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 34b6ed2 Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 34b6ed2 Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 34b6ed2 Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 34b6ed2 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 34b6ed2 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 34b6ed2 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 34b6ed2 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 34b6ed2 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 34b6ed2 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 34b6ed2 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 34b6ed2 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 34b6ed2 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 34b6ed2 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 34b6ed2 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 34b6ed2 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 34b6ed2 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 34b6ed2 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 34b6ed2 Reason: push, by tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…enot,smaug Add more color spaces introduced by w3c/webcodecs#566 Differential Revision: https://phabricator.services.mozilla.com/D161224
…enot,smaug Add more color spaces introduced by w3c/webcodecs#566 Differential Revision: https://phabricator.services.mozilla.com/D161224
This implements the color spaces portion of #384, but does not add pixel formats or HDR metadata.
Preview | Diff