Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cssom-1] Merge constructable stylesheets into CSSOM (https://lists.w3.org/Archives/Public/www-style/2020Feb/0012.html) #6304

Merged
merged 2 commits into from
Jun 16, 2021

Conversation

mfreed7
Copy link

@mfreed7 mfreed7 commented May 22, 2021

[cssom-1] Merge constructable stylesheets into CSSOM (https://lists.w3.org/Archives/Public/www-style/2020Feb/0012.html)

This is a first PR to merge the Constructable Stylesheets proposal into the CSSOM spec. This was resolved in Feb 2020: https://lists.w3.org/Archives/Public/www-style/2020Feb/0012.html. There are several sub-resolutions there, a few of which are handled here:

...and a few of which will follow this PR:

Closes #3433, Closes WICG/construct-stylesheets#102, Closes WICG/construct-stylesheets#90

P.S. This is my first CSSWG PR. Please go easy on me and let me know what I can do better. 😄

@mfreed7
Copy link
Author

mfreed7 commented Jun 1, 2021

Any thoughts here? @emilio

Copy link
Collaborator

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry for the lag. This looks sensible to me. Maybe @tabatkins has some editorial comments or something? But otherwise this seems good to merge to me.

I assume the DocumentOrShadowRoot.adoptedStyleSheets etc definitions should get merged-in later?

@mfreed7
Copy link
Author

mfreed7 commented Jun 3, 2021

Hey, sorry for the lag. This looks sensible to me. Maybe @tabatkins has some editorial comments or something? But otherwise this seems good to merge to me.

I assume the DocumentOrShadowRoot.adoptedStyleSheets etc definitions should get merged-in later?

Great, thanks! I'm happy to make modifications, just let me know.

As for adoptedStyleSheets, yes, I was thinking about handling that in a followup PR, just to separate constructable stylesheets from their use. If you think it needs to be combined, let me know.

@mfreed7
Copy link
Author

mfreed7 commented Jun 10, 2021

Hey, sorry for the lag. This looks sensible to me. Maybe @tabatkins has some editorial comments or something? But otherwise this seems good to merge to me.
I assume the DocumentOrShadowRoot.adoptedStyleSheets etc definitions should get merged-in later?

Great, thanks! I'm happy to make modifications, just let me know.

As for adoptedStyleSheets, yes, I was thinking about handling that in a followup PR, just to separate constructable stylesheets from their use. If you think it needs to be combined, let me know.

Any further thoughts @emilio @tabatkins ? Anything else I need to do in order to get this landed?

@mfreed7
Copy link
Author

mfreed7 commented Jun 15, 2021

Any further thoughts @emilio @tabatkins ? Anything else I need to do in order to get this landed?

Friendly ping @emilio and @tabatkins, thanks!

@emilio emilio merged commit 207dd1e into w3c:main Jun 16, 2021
@emilio
Copy link
Collaborator

emilio commented Jun 16, 2021

LGTM, thanks for this @mfreed7 (and sorry, I'm really slow with gh notifications lately :/)

@mfreed7
Copy link
Author

mfreed7 commented Jun 16, 2021

LGTM, thanks for this @mfreed7 (and sorry, I'm really slow with gh notifications lately :/)

No problem at all (I'm even more guilty of that) and thanks for merging this.

I will now get started on the other parts, mentioned in the original comment here.

foolip added a commit to web-platform-tests/wpt that referenced this pull request Apr 25, 2024
foolip added a commit to web-platform-tests/wpt that referenced this pull request May 6, 2024
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request May 8, 2024
…ative, a=testonly

Automatic update from web-platform-tests
Make CSSStyleSheet baseURL test non-tentative (#45903)

It was spec'd a long time ago:
w3c/csswg-drafts#6304
--

wpt-commits: 7bea4f8a47e6f245c01e2b7cd740df5895a1727b
wpt-pr: 45903
ErichDonGubler pushed a commit to erichdongubler-mozilla/firefox that referenced this pull request May 10, 2024
…ative, a=testonly

Automatic update from web-platform-tests
Make CSSStyleSheet baseURL test non-tentative (#45903)

It was spec'd a long time ago:
w3c/csswg-drafts#6304
--

wpt-commits: 7bea4f8a47e6f245c01e2b7cd740df5895a1727b
wpt-pr: 45903
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this pull request Jun 6, 2024
…ative, a=testonly

Automatic update from web-platform-tests
Make CSSStyleSheet baseURL test non-tentative (#45903)

It was spec'd a long time ago:
w3c/csswg-drafts#6304
--

wpt-commits: 7bea4f8a47e6f245c01e2b7cd740df5895a1727b
wpt-pr: 45903
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants