Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Changes for v1.2 #719

Merged
merged 2 commits into from
Jun 20, 2018
Merged

Initial Changes for v1.2 #719

merged 2 commits into from
Jun 20, 2018

Conversation

jnurthen
Copy link
Member

@jnurthen jnurthen commented Jun 15, 2018

Changed version numbers for v1.2.
Removed Changelog


Preview | Diff

Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great except for the one problem of what to do for editor's draft URI.

respec-config.js Outdated
@@ -30,7 +30,7 @@ var respecConfig = {
// previousDiffURI: "",

// If there a publicly available Editors Draft, this is the link
edDraftURI: 'https://w3c.github.io/aria-practices/',
edDraftURI: 'https://w3c.github.io/aria-practices-1.2/',
Copy link
Contributor

@mcking65 mcking65 Jun 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work ... the path in the gh-pages URI is the repo name. We don't have a separate repo for 1.2.

One quick fix option is to use rawgit.
https://rawgit.com/w3c/aria-practices/apg-1.2/aria-practices.html
However, github says not to drive public traffic to rawgit. So, this would have to be just a stopgap until we can do something better.

A possibility for something better is to restructure the entire gh-pages branch to have a 1.1 dir and a 1.2 dir and then reconfig travis so that it always builds both from the master and apg-1.2 branches and puts the build output from master into the 1.1 dir and the build output from apg-1.2 in the 1.2 dir.

I suspect @michael-n-cooper may have an opinion; not sure if having two different directories in gh-pages would complicate publication or not.

@jnurthen
Copy link
Member Author

Set ED location to rawgit for now. I kind of knew this was wrong - but hadn't thought of using rawgit. I think this is fine in the short term. I don't think we should expect a lot of Editor's draft traffic for now.

@mcking65 mcking65 merged commit 9abf6c4 into apg-1.2 Jun 20, 2018
@mcking65 mcking65 added this to the 1.2 APG Working Draft 1 milestone Jun 20, 2018
@mcking65 mcking65 deleted the 1.2Versioning branch December 18, 2018 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants