Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessible Names Practice: Recommend association via 'for' attribute when using 'label' element #2882

Merged
merged 8 commits into from
Dec 18, 2023
Merged

Accessible Names Practice: Recommend association via 'for' attribute when using 'label' element #2882

merged 8 commits into from
Dec 18, 2023

Commits on Dec 6, 2023

  1. Recommend use of 'for' over labeling by encapsulation

    @mcking65
    mcking65 committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    8430230 View commit details
    Browse the repository at this point in the history

  2. Correct heading level (h3 to h4) on warning

    @mcking65
    mcking65 committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    bc26404 View commit details
    Browse the repository at this point in the history

  3. satis fy linter

    @mcking65
    mcking65 committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    679fdc8 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2023

  1. Apply Patrick's suggestions from code review 

    Co-authored-by: Patrick H. Lauke <redux@splintered.co.uk>
    @mcking65 @patrickhlauke
    mcking65 and patrickhlauke authored Dec 10, 2023
    Configuration menu
    Copy the full SHA
    670addc View commit details
    Browse the repository at this point in the history

  2. Address feedback from Patrick

    @mcking65
    mcking65 committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    4528f2e View commit details
    Browse the repository at this point in the history

  3. Improve paragraph structure

    @mcking65
    mcking65 committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    5fe78a3 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Revise text to include the terms explicit and implicit association

    @mcking65
    mcking65 committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    d6f03eb View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2023

  1. Further refine based on feedback

    @mcking65
    mcking65 committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    fc57d9b View commit details
    Browse the repository at this point in the history